Skip to content

[Bookings] Add clear option for date filter #16408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 27, 2025
Merged

[Bookings] Add clear option for date filter #16408

merged 4 commits into from
Nov 27, 2025
+45 −0

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Nov 26, 2025 •
edited
Loading

WOOMOB-1806

Description

  • Adds clear button in Date & time filter screen for bookings
  • Clear button is disabled when no date/time filter options are selected

Test Steps

  • Use CIAB site with bookings
  • Navigate to bookings list and select "All" tab to reveal bookings filter option
  • Tap on "Filter" option
  • Tap on "Date & time" option
  • While there is no date / time selection yet - make sure the "Clear" button is displayed as disabled
  • Make date / time range selection
  • Make sure the "Clear" button becomes enabled as soon as there is date / time interval selection.
  • Tap on "Clear" button. Make sure date / time selection is cleared.
  • Tap on "<" back item in toolbar.
  • Make sure that the "Date & time" selection is cleared and presents "Any" in "Filters" screen.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-26.at.17.12.29.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.8 milestone Nov 26, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Nov 26, 2025
@RafaelKayumov RafaelKayumov changed the title Woomob 1806 add clear option for date filter [Bookings] Add clear option for date filter Nov 26, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 26, 2025 •
edited
Loading

1 Warning
⚠️ This PR is assigned to the milestone 23.8. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 26, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16408-045ba00
Version23.7
Bundle IDcom.automattic.alpha.woocommerce
Commit045ba00
Installation URL6bjhkpjonhl98
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo self-assigned this Nov 27, 2025
itsmeichigo
itsmeichigo approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

One minor nit-picking: I wonder if we should keep the UX consistent between the date filter view and the main filter view. Currently in the main filter view, the Clear All button is hidden when there are no filter. On the date filter view, the Clear button is simply disabled.

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-27.at.09.29.12.mov

@RafaelKayumov
Copy link
Contributor Author

RafaelKayumov commented Nov 27, 2025

LGTM :shipit:

One minor nit-picking: I wonder if we should keep the UX consistent between the date filter view and the main filter view. Currently in the main filter view, the Clear All button is hidden when there are no filter. On the date filter view, the Clear button is simply disabled.

Simulator.Screen.Recording.-.iPhone.17.-.2025-11-27.at.09.29.12.mov

Done in c02ddcf

@RafaelKayumov RafaelKayumov merged commit d647f44 into trunk Nov 27, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1806-add-clear-option-for-date-filter branch November 27, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

@adborbas adborbas Awaiting requested review from adborbas

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.8 ❄️

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelKayumov @dangermattic @wpmobilebot @itsmeichigo